Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ETHEREUM-CONTRACTS] add IERC20Metadata to SuperfluidPool #2046

Merged
merged 5 commits into from
Dec 27, 2024
Merged

[ETHEREUM-CONTRACTS] add IERC20Metadata to SuperfluidPool #2046

merged 5 commits into from
Dec 27, 2024

Conversation

d10r
Copy link
Collaborator

@d10r d10r commented Dec 23, 2024

Due to a community request we add ERC20 metadata to Superfluid Pools.

  • customizable at pool creation
  • default values for legacy pools and new pools not setting custom values

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 23, 2024 •
edited by d10r
Loading

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

@d10r d10r marked this pull request as ready for review December 23, 2024 19:28
@d10r d10r requested a review from hellwolf as a code owner December 23, 2024 19:28
@d10r d10r merged commit d199860 into dev Dec 27, 2024
18 checks passed
@d10r d10r deleted the pool-erc20-metadata branch December 27, 2024 16:26
@github-actions GitHub Actions
Copy link

XKCD Comic Relif

Link: https://xkcd.com/2046
https://xkcd.com/2046

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellwolf hellwolf hellwolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d10r @hellwolf